netplay: assorted minor fixes #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManManson
force-pushed
the
netplay_minor_refactoring
branch
from
1904bbc to
03dbe51
Compare
…s const Signed-off-by: Pavel Solodovnikov <[email protected]>
`socketArrayOpen` and `socketArrayClose` weren't used anywhere, so remove them. Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
netplay_minor_refactoring
branch
from
dcc7ca5 to
c3bf828
Compare
ManManson
force-pushed
the
netplay_minor_refactoring
branch
from
c3bf828 to
5533421
Compare
Signed-off-by: Pavel Solodovnikov <[email protected]>
It's not used outside of `netplay.cpp`, so can be made `static`. Signed-off-by: Pavel Solodovnikov <[email protected]>
ManManson
force-pushed
the
netplay_minor_refactoring
branch
from
5533421 to
30894f2
Compare
past-due
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WZFileto a separate source file.WZFileshould probably be renamed toWZDownloadingFileor something like that, but I've decided to keep its name for a bit longer. At least moving it to a separate file looks better than before.syncDebug*related functions to a separate source file.netplay.handnetsocket.hSigned-off-by: Pavel Solodovnikov [email protected]